PiotrZSL added a comment. Just few nits, from functionally point of view looks fine.
================ Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357 + if (ArgCount) + ArgRotates.push_back( + std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount)); +} ---------------- ================ Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector<std::tuple<unsigned, unsigned>> ArgRotates; + ---------------- NOTE: You can use std::pair here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154283/new/ https://reviews.llvm.org/D154283 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
