efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

The testcase doesn't actually trigger the assertion... but I guess it still 
tests the output, so that's probably okay?  Maybe add a case `static 
_Atomic(int *) glob_pointer_from_long = 0LL;` just to be sure.

Otherwise LGTM

(The "VarSize == CstSize" assertion has been catching a surprising number of 
cases of bad codegen; I'm happy I spent the time to add it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154284/new/

https://reviews.llvm.org/D154284

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to