jroelofs added a comment.

> It seems to me that maybe anything with OS none (although that doesn’t seem 
> to be distinguished from unknown)

I considered splitting `none` from `unknown` in Triple, but never had the time 
to do it. I think this would be good for baremetal toolchains in light of the 
gcc installation detection machinery taking over whenever there isn't otherwise 
a match.

> or with environment eabi should be treated as bare-metal, but I don’t have a 
> lot of experience in this regard.

IIRC there are `arm-linux-eabi` toolchains in the wild, which are not baremetal.



================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:168
+
+  if (Triple.getVendor() != llvm::Triple::UnknownVendor)
+    return false;
----------------
does this break your use cases re: having `indel` as the vendor? or will you 
have a downstream patch to exempt `indel` from this check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154357/new/

https://reviews.llvm.org/D154357

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to