mboehme updated this revision to Diff 537029. mboehme added a comment. Actually make the test pass. It was missing an indirection.
No idea how I missed this on the initial upload... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154421/new/ https://reviews.llvm.org/D154421 Files: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp Index: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp =================================================================== --- clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -656,6 +656,30 @@ }); } +TEST(TransferTest, DirectlySelfReferentialReference) { + std::string Code = R"( + struct target { + target() { + (void)0; + // [[p]] + } + target &self = *this; + }; + )"; + runDataflow( + Code, + [](const llvm::StringMap<DataflowAnalysisState<NoopLattice>> &Results, + ASTContext &ASTCtx) { + const Environment &Env = getEnvironmentAtAnnotation(Results, "p"); + const ValueDecl *SelfDecl = findValueDecl(ASTCtx, "self"); + + auto *ThisLoc = Env.getThisPointeeStorageLocation(); + auto *RefVal = + cast<ReferenceValue>(Env.getValue(ThisLoc->getChild(*SelfDecl))); + ASSERT_EQ(&RefVal->getReferentLoc(), ThisLoc); + }); +} + TEST(TransferTest, MultipleVarsDecl) { std::string Code = R"( void target() {
Index: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp =================================================================== --- clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -656,6 +656,30 @@ }); } +TEST(TransferTest, DirectlySelfReferentialReference) { + std::string Code = R"( + struct target { + target() { + (void)0; + // [[p]] + } + target &self = *this; + }; + )"; + runDataflow( + Code, + [](const llvm::StringMap<DataflowAnalysisState<NoopLattice>> &Results, + ASTContext &ASTCtx) { + const Environment &Env = getEnvironmentAtAnnotation(Results, "p"); + const ValueDecl *SelfDecl = findValueDecl(ASTCtx, "self"); + + auto *ThisLoc = Env.getThisPointeeStorageLocation(); + auto *RefVal = + cast<ReferenceValue>(Env.getValue(ThisLoc->getChild(*SelfDecl))); + ASSERT_EQ(&RefVal->getReferentLoc(), ThisLoc); + }); +} + TEST(TransferTest, MultipleVarsDecl) { std::string Code = R"( void target() {
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits