sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:497 TEST(DocumentSymbols, ExportContext) { + Config EnableModules; + EnableModules.CompileFlags.NaiveModules = true; ---------------- For existing tests of how modules interacts with other features, testing these with modules-enabled seems sufficient. For tests that were specifically about modules, I think it makes sense to test in both modes (behavior may differ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155392/new/ https://reviews.llvm.org/D155392 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits