kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, i think this LG. ================ Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1697-1698 + )cpp"); + TU.HeaderFilename = "Foo.h"; + auto Symbols = TU.headerSymbols(); + EXPECT_THAT(Symbols, Not(Contains(qName("HEADER_GUARD_")))); ---------------- `headerSymbols` still uses `Filename` not `HeaderFilename` of the TU. ================ Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1699-1702 + EXPECT_THAT(Symbols, Not(Contains(qName("HEADER_GUARD_")))); + EXPECT_THAT(Symbols, Contains(qName("MACRO"))); + EXPECT_THAT(Symbols, Contains(qName("MACRO2"))); + EXPECT_THAT(Symbols, Contains(qName("decl"))); ---------------- i think we don't want to just check for names of the symbols, but also want to make sure they got proper include headers assigned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78038/new/ https://reviews.llvm.org/D78038 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits