Author: Martin Braenne Date: 2023-07-20T12:40:22Z New Revision: 8b5d3ba829c162fd4890fd65a4629ce0715825ee
URL: https://github.com/llvm/llvm-project/commit/8b5d3ba829c162fd4890fd65a4629ce0715825ee DIFF: https://github.com/llvm/llvm-project/commit/8b5d3ba829c162fd4890fd65a4629ce0715825ee.diff LOG: [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests. This makes it easier to determine which line the unexpected happened on; previously, we would only get the line number. Reviewed By: ymandel Differential Revision: https://reviews.llvm.org/D155802 Added: Modified: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp Removed: ################################################################################ diff --git a/clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp b/clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp index 4bac015c995f68..a181f284370886 100644 --- a/clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp @@ -12,6 +12,7 @@ #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchers.h" #include "clang/Basic/SourceLocation.h" +#include "clang/Frontend/TextDiagnostic.h" #include "clang/Tooling/Tooling.h" #include "llvm/ADT/DenseSet.h" #include "llvm/ADT/STLExtras.h" @@ -1334,7 +1335,17 @@ class UncheckedOptionalAccessTest auto &SrcMgr = AO.ASTCtx.getSourceManager(); llvm::DenseSet<unsigned> DiagnosticLines; for (SourceLocation &Loc : Diagnostics) { - DiagnosticLines.insert(SrcMgr.getPresumedLineNumber(Loc)); + unsigned Line = SrcMgr.getPresumedLineNumber(Loc); + DiagnosticLines.insert(Line); + if (!AnnotationLines.contains(Line)) { + IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts( + new DiagnosticOptions()); + TextDiagnostic TD(llvm::errs(), AO.ASTCtx.getLangOpts(), + DiagOpts.get()); + TD.emitDiagnostic( + FullSourceLoc(Loc, SrcMgr), DiagnosticsEngine::Error, + "unexpected diagnostic", std::nullopt, std::nullopt); + } } EXPECT_THAT(DiagnosticLines, ContainerEq(AnnotationLines)); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
