alexshap added a subscriber: alexshap.
================
Comment at: change-namespace/ChangeNamespace.cpp:125
@@ +124,3 @@
+// applying all existing Replaces first if there is conflict.
+void addOrMergeReplacement(const tooling::Replacement &R,
+ tooling::Replacements *Replaces) {
----------------
khm, this seems to be a recurring pattern (if i'm not mistaken),
looks like the interface of tooling::Replacements can be changed/improved
(although i don't know).
Another (separate) observation is about duplicates. For example for
replacements in headers we can get into if(Err) branch pretty frequently
because the same replacement can be generated multiple times (if that header is
included into several *.cpp files).
https://reviews.llvm.org/D24183
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
