aaron.ballman added inline comments.
================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1201
+ const char testSource[] = R"cpp(
+#include <string_view>
+static constexpr std::string_view message{"Hello World!"};
----------------
This is going to be testing whatever STL headers are installed on the
developer's machine; instead of including the STL header, you should mock up
the `std::string_view` class so we're always testing something consistently.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156053/new/
https://reviews.llvm.org/D156053
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
