shafik added inline comments.

================
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+        if (FnDecl->isInvalidDecl())
+          return ExprError();
----------------
shafik wrote:
> It feels a bit weird that we are succeeding in finding the best viable 
> function and what we find is invalid. 
It looks like we have a couple of test that generate the `cannot be variadic` 
diagnostic for overloads e.g. `clang/test/SemaCXX/overloaded-operator-decl.cpp` 
it might be worth looking into why they don't crash and this case does. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156244/new/

https://reviews.llvm.org/D156244

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to