zahiraam marked 2 inline comments as done.
zahiraam added inline comments.
================
Comment at: clang/include/clang/Basic/LangOptions.h:857
setAllowApproxFuncOverride(!Value);
+ setMathErrnoOverride(Value);
if (Value)
----------------
aaron.ballman wrote:
> zahiraam wrote:
> > aaron.ballman wrote:
> > > Everything else does `!Value`; is it intentional that you're using
> > > `Value` instead?
> > Yes. I want to set the value of math-errno to the value of the pragma in
> > the source.
> Hmm, okay. Making sure I understand the logic, please excuse me if this is a
> dumb question. :-) So the idea here is that if fp_precise is on, we have to
> honor math errno, and if fp_precise is off, we can ignore math errno?
Correct.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151834/new/
https://reviews.llvm.org/D151834
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
