tahonermann added a comment.
I think I'm happy with this. I noted two code changes that I think are no
longer needed and offered some final suggestions on some names.
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:118-120
+def ext_expand_predef_ms : ExtWarn<
+ "expansion of predefined identifier '%0' to a string literal is a Microsoft
extension">,
+ InGroup<MicrosoftConcatPredefined>;
----------------
For consistency with other names, I'll suggest some alternative names here. I
think these better reflect the actual diagnostic message.
- ext_expand_predef_ms -> ext_string_literal_from_predefined
- MicrosoftConcatPredefined -> MicrosoftStringLiteralFromPredefined
================
Comment at: clang/include/clang/Basic/TokenKinds.h:22-23
+class LangOptions;
+
namespace tok {
----------------
It looks like this change is no longer needed.
================
Comment at: clang/lib/Basic/TokenKinds.cpp:14-15
#include "clang/Basic/TokenKinds.h"
+
+#include "clang/Basic/LangOptions.h"
#include "llvm/Support/ErrorHandling.h"
----------------
This change appears to no longer be needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153914/new/
https://reviews.llvm.org/D153914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
