rmaprath added a comment. In https://reviews.llvm.org/D21968#534462, @EricWF wrote:
> This looks great. Two comments: > > 1. The declarations should be used in both the inline and external pthread > implementation. They also need visibility declarations. > 2. Why can't we use the inline implementation to implement > `external_threads.cpp`? > > I took a stab at it here > <https://gist.github.com/EricWF/0edfd18c22cd50a5f34fd11674f4eda9>. Yup, that looks better. I will incorporate this change and also address the remaining comments from @compnerd before I commit. Thanks all! / Asiri https://reviews.llvm.org/D21968 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
