Fznamznon added inline comments.
================ Comment at: clang/lib/Parse/ParseDecl.cpp:422 + // There's nothing to suggest in here as we parsed a full expression. + // Instead fail and propogate the error since caller might have something + // the suggest, e.g. signature help in function call. Note that this is ---------------- ================ Comment at: clang/lib/Parse/ParseDecl.cpp:433-434 + SawError = true; + break; + SkipUntil(tok::comma, tok::r_paren, StopBeforeMatch); + } else { ---------------- Should it be Also, probably else can be removed since there is break above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156237/new/ https://reviews.llvm.org/D156237 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits