aaron.ballman added inline comments.
================
Comment at: clang/test/AST/Interp/builtin-functions.cpp:65-73
+ constexpr float f1 = __builtin_fmin(1.0, 2.0f);
+ static_assert(f1 == 1.0f, "");
+
+ constexpr float min = __builtin_fmin(__builtin_nan(""), 1);
+ static_assert(min == 1, "");
+ constexpr float min2 = __builtin_fmin(1, __builtin_nan(""));
+ static_assert(min2 == 1, "");
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Can you add a test using `__builtin_nans` to show that it results in an
> > invalid constant expression because of the `FE_INVALID` signal?
> It doesn't currently result in an invalid constant expression in clang (both
> new and current interpreter). Where should that signal occur? Or do I need to
> check for signaling nans whenever I compute a floating value?
That's the way that I would approach it (to check for a signaling NaN any time
you need its value) and I think that's the same as the suggestion from
@jcranmer-intel.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155546/new/
https://reviews.llvm.org/D155546
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
