aaron.ballman added inline comments. ================ Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:34 @@ +33,3 @@ + const auto *Construct = Result.Nodes.getNodeAs<CXXConstructExpr>("construct"); + const auto arguments = Construct->arguments(); + ---------------- sbenza wrote: > Prazek wrote: > > Arguments (upper case) > Arguments variable name. (should start with upper case) Please do not use `auto` here, since the type is not spelled out in the initializer.
================ Comment at: clang-tidy/readability/RedundantMemberInitCheck.h:19 @@ +18,3 @@ + +/// Find unnecessary member initializers +/// ---------------- What makes one unnecessary? Also, missing a full stop at the end of the sentence. Repository: rL LLVM https://reviews.llvm.org/D24339 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits