zixuan-wu added inline comments.
================ Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + ---------------- benshi001 wrote: > This file is pure test, has nothing to do with `llvm.cttz`, just to avoid > another patch. Don't make unrelated patch together in one single commit. ================ Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:67 + return __builtin_bswap64(x); +} ---------------- Those are target-independent intrinsics/builtins. I think it's no more need to test for specific target such as csky again, unless it's different behavior or output. ================ Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:36 +define i16 @bswap16(i16 %x) { +; CHECK-LABEL: bswap16: +; CHECK: # %bb.0: # %entry ---------------- Again. It's related to cttz? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits