aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LG aside from a nit. ================ Comment at: clang/lib/AST/Interp/Interp.cpp:558-561 + if (VD->getType()->isIntegralOrEnumerationType()) + S.FFDiag(E, diag::note_constexpr_ltor_non_const_int, 1) << VD; + else + S.FFDiag(E, diag::note_constexpr_ltor_non_constexpr, 1) << VD; ---------------- Plus reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156511/new/ https://reviews.llvm.org/D156511 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits