aeubanks added inline comments.
================
Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:1
+;; Check that SimplifyCFG does not attempt speculation until after PGO is
+;; annotated in the IR, and then does not perform it when unprofitable.
----------------
hmm typically these phase ordering tests use
`llvm/utils/update_test_checks.py`, but that doesn't support the llvm-profdata
RUN line. I think a non-update_test_checks test is probably fine for this,
@nikic does that make sense?
================
Comment at:
llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:22
+; RUN: opt < %s -passes='thinlto-pre-link<O2>'
-pgo-kind=pgo-sample-use-pipeline
-profile-file=%S/Inputs/simplifycfg-speculate-blocks.sampleprof -S | FileCheck
%s --check-prefixes=NO,SAMPLE
+; RUN: opt < %s -passes='thinlto-pre-link<O2>'
-pgo-kind=pgo-sample-use-pipeline
-profile-file=%S/Inputs/simplifycfg-speculate-blocks.sampleprof -S | FileCheck
%s --check-prefixes=NO,SAMPLE
+
----------------
`lto-pre-link`
================
Comment at:
llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:83
+!4 = !{i32 1, !"wchar_size", i32 4}
+!5 = !{i32 8, !"PIC Level", i32 2}
+!6 = !{i32 7, !"PIE Level", i32 2}
----------------
the debug info is necessary for sample profile to work I presume?
I think some of this can still be simplified, like `PIC Level`, etc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155997/new/
https://reviews.llvm.org/D155997
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
