sousajo added a comment.

In D156624#4545107 <https://reviews.llvm.org/D156624#4545107>, @PiotrZSL wrote:

> Good, just verify that documentation for this check is still proper, and add 
> entry in release notes about this change.

I missed those, I will sure ^^

In D156624#4545117 <https://reviews.llvm.org/D156624#4545117>, @carlosgalvezp 
wrote:

> What about the use case of privately inheriting `std::array`, and overriding 
> the `operator[]` there with bounds check? I believe there shouldn't be 
> warnings there.
>
> Would it be possible to check only _public_ inheritance?

Good point, I cannot think of an _easy_ way to check it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156624/new/

https://reviews.llvm.org/D156624

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to