vsapsai added a comment. Thanks for the quick review!
In D156749#4549226 <https://reviews.llvm.org/D156749#4549226>, @ChuanqiXu wrote: > Although there is a FIXME in the definition of `getNameAsRequested()`, it > looks not sense to require you to fix that. It might not be an over burden > for someone who will be intended to fix this later. So LGTM. I've discussed with @jansvoboda11 the future of `FileEntryRef::getNameAsRequested` and it is supposed to replace `FileEntryRef::getName` (eventually, not immediately), if I understand correctly. Given that, it is the move in the right direction regardless of FIXMEs. If I've misunderstood something, Jan can chime in and correct me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156749/new/ https://reviews.llvm.org/D156749 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
