nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1432
TEST(TypeHints, SubstTemplateParameterAliases) {
+ llvm::StringRef Header = R"cpp(
----------------
zyounan wrote:
> I feel like this test is becoming clunky: The validations here require an
> invented class template `vector` which I think should be better placed in a
> header; however, in the remaining snippet, it seems that I'm testing too many
> hints in one `assertHint` call. Should I split these cases into different
> snippets, or we just leave them as-is at the moment?
I think this is fine as-is for now
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
