kiranchandramohan added a comment. > rpass flag now prints remarks when requested but does not display > the passName used, i.e [-Rpass=inline]
I think the location information is also not printed. Please check the difference in implementation of the `TextDiagnosticPrinter::HandleDiagnostic` function in clang (https://github.com/llvm/llvm-project/blob/7240008c0afa3e2d12f3f51cfe0235668feb6ef3/clang/lib/Frontend/TextDiagnosticPrinter.cpp#L109) and flang (https://github.com/llvm/llvm-project/blob/7240008c0afa3e2d12f3f51cfe0235668feb6ef3/flang/lib/Frontend/TextDiagnosticPrinter.cpp#L32). In particular, the passName is printed in the printDiagnosticOptions function https://github.com/llvm/llvm-project/blob/7240008c0afa3e2d12f3f51cfe0235668feb6ef3/clang/lib/Frontend/TextDiagnosticPrinter.cpp#L85 ================ Comment at: clang/lib/Basic/DiagnosticIDs.cpp:796-797 Diag.ErrorOccurred = true; - if (Diag.Client->IncludeInDiagnosticCounts()) { + if (Diag.Client->IncludeInDiagnosticCounts()) ++Diag.NumErrors; ---------------- Looks like an unrelated change. ================ Comment at: clang/lib/CodeGen/CodeGenAction.cpp:772 - Diags.Report(Loc, DiagID) - << AddFlagValue(D.getPassName()) - << MsgStream.str(); + Diags.Report(Loc, DiagID) << AddFlagValue(D.getPassName()) << MsgStream.str(); ---------------- Looks like an unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
