gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:258
+  
static_assert(__is_trivially_relocatable(TrivialAbiAttributeAppliedToAnonymousUnion),
 "");
+#endif
+
----------------
Is it possible to restructure the ifdefs to only wrap the different parts?

That is, you can place only the `expected-warning` line and `static_assert` 
lines within ifdefs. You can use the `@`-syntax on `expected-warning` to tell 
clang to expect the warning on a different line, for example see 
`test/SemaCXX/deprecated.cpp`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155895/new/

https://reviews.llvm.org/D155895

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to