tianshilei1992 added inline comments.
================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4065 + Constant *KernelEnvironmentGV = new GlobalVariable( + M, KernelEnvironment, /* IsConstant */ true, GlobalValue::ExternalLinkage, + KernelEnvironmentInitializer, KernelEnvironmentName, ---------------- dhruvachak wrote: > Is there a reason this has to be ExternalLinkage? Can we use > GlobalValue::WeakAnyLinkage here? The external linkage leads to multiply > defined linker errors downstream on test cases that have a target region in a > header file. For some reason, the problem does not repro on the main branch. > @tianshilei1992 @jdoerfert It has been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
