rsandifo-arm added inline comments.
================
Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181
+void non_za_definition(void) {
+ sme_arm_new_za(); // OK
----------------
sdesmalen wrote:
> rsandifo-arm wrote:
> > Would be good to have some tests for indirect function calls too (via
> > function pointers), to make sure that the diagnostic still works when no
> > decl is available.
> >
> > I suppose this applies to D157269 too.
> I'm not sure that's necessary because D127762 already added tests to ensure
> the attributes propagate on pointer types, which then sets the ExtProtoInfo
> for those values. This patch merely checks the SME attribute fields from
> ExtProtoInfo. i.e. there is already nothing depending on a declaration being
> available.
But `Sema::checkCall` does have some tests that depend on the decl rather than
the type. So the purpose of the test wouldn't be “does the attribute stick
when applied to indirect function types?” (which I agree is already covered),
but “does the new code correctly process the attribute on the target of a
function pointer type?”
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157270/new/
https://reviews.llvm.org/D157270
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
