cor3ntin added inline comments.
================ Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs<ReferenceType>(); + Method->getNonObjectParameter(0)->getType()->getAs<ReferenceType>(); if (!ParamTy || ParamTy->getPointeeType().isConstQualified()) ---------------- cor3ntin wrote: > aaron.ballman wrote: > > Under what circumstances should existing calls to `getParamDecl()` be > > converted to using `getNonObjectParameter()` instead? Similar for > > `getNumParams()`. > everytime you want to ignore (or handle differently) the explicit object > parameter. I'll do another survey at some point, to be sure i didn't miss a > spot I found a bug https://github.com/cplusplus/CWG/issues/390 ! (`AreSpecialMemberFunctionsSameKind`) - So far nothing else but I'll do several passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140828/new/ https://reviews.llvm.org/D140828 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits