fwolff created this revision. fwolff added reviewers: PiotrZSL, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits.
Fixes a simple oversight which currently causes the `AllowIntegerConditions` option of the `readability-implicit-bool-conversion` check to not apply to do-while loop conditions, for no apparent reason. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157428 Files: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp Index: clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp =================================================================== --- clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp +++ clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp @@ -38,6 +38,9 @@ while (functionReturningInt()) {} while (functionReturningPointer()) {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())) {} + do {} while (functionReturningInt()); + do {} while (functionReturningPointer()); + do {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())); int value1 = functionReturningInt() ? 1 : 2; int value2 = !functionReturningInt() ? 1 : 2; int value3 = (functionReturningInt() && functionReturningPointer() || !functionReturningInt()) ? 1 : 2; Index: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp =================================================================== --- clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp +++ clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp @@ -228,7 +228,8 @@ if (!S) return false; if (isa<IfStmt>(S) || isa<ConditionalOperator>(S) || isa<ForStmt>(S) || - isa<WhileStmt>(S) || isa<BinaryConditionalOperator>(S)) + isa<WhileStmt>(S) || isa<DoStmt>(S) || + isa<BinaryConditionalOperator>(S)) return true; if (isa<ParenExpr>(S) || isa<ImplicitCastExpr>(S) || isUnaryLogicalNotOperator(S) ||
Index: clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp =================================================================== --- clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp +++ clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp @@ -38,6 +38,9 @@ while (functionReturningInt()) {} while (functionReturningPointer()) {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())) {} + do {} while (functionReturningInt()); + do {} while (functionReturningPointer()); + do {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())); int value1 = functionReturningInt() ? 1 : 2; int value2 = !functionReturningInt() ? 1 : 2; int value3 = (functionReturningInt() && functionReturningPointer() || !functionReturningInt()) ? 1 : 2; Index: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp =================================================================== --- clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp +++ clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp @@ -228,7 +228,8 @@ if (!S) return false; if (isa<IfStmt>(S) || isa<ConditionalOperator>(S) || isa<ForStmt>(S) || - isa<WhileStmt>(S) || isa<BinaryConditionalOperator>(S)) + isa<WhileStmt>(S) || isa<DoStmt>(S) || + isa<BinaryConditionalOperator>(S)) return true; if (isa<ParenExpr>(S) || isa<ImplicitCastExpr>(S) || isUnaryLogicalNotOperator(S) ||
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits