aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits.
================ Comment at: clang/docs/ReleaseNotes.rst:126-127 of a base class is not called in the constructor of its derived class. +- Clang no longer emits `-Wmissing-variable-declarations` for variables declared + with the `register` storage class. ---------------- Sphinx fixes ================ Comment at: clang/test/Sema/warn-missing-variable-declarations-register.c:2 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -Wmissing-variable-declarations -fsyntax-only -verify %s +// REQUIRES: x86-registered-target +// expected-no-diagnostics ---------------- nickdesaulniers wrote: > @aaron.ballman do we need this REQUIRES clause? Nope, no need for `REQUIRES` here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157435/new/ https://reviews.llvm.org/D157435 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
