aaron.ballman added a comment. In D155383#4507928 <https://reviews.llvm.org/D155383#4507928>, @strimo378 wrote:
> There are many ast-dump tests about decls but there are nearly no other type > tests. We should still be adding tests for these changes, to ensure we don't regress the behavior later by accident. It also helps the code reviewers to see what the output looks like and whether we spot any concerns with it. ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1549 + case EST_DynamicNone: + OS << " exceptionspec_dynamicnone"; + break; ---------------- ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1555 + case EST_MSAny: + OS << " exceptionspec_msany"; + break; ---------------- ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1561 + case EST_BasicNoexcept: + OS << " exceptionspec_basicnoexcept"; + break; ---------------- ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1564 + case EST_DependentNoexcept: + OS << " exceptionspec_dependentnoexcept"; + break; ---------------- ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1567 + case EST_NoexceptFalse: + OS << " exceptionspec_noexceptfalse"; + break; ---------------- ================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1570 + case EST_NoexceptTrue: + OS << " exceptionspec_noexcepttrue"; + break; ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
