awarzynski accepted this revision.
awarzynski added a comment.
LG, with a small suggestion :) (in the spirit of cleaning up Options.td)
================
Comment at: clang/include/clang/Driver/Options.td:819-831
+def Rpass_EQ : Joined<["-"], "Rpass=">, Group<R_value_Group>,
Flags<[CC1Option, FlangOption, FC1Option]>,
HelpText<"Report transformations performed by optimization passes whose "
"name matches the given POSIX regular expression">;
def Rpass_missed_EQ : Joined<["-"], "Rpass-missed=">, Group<R_value_Group>,
- Flags<[CC1Option]>,
+ Flags<[CC1Option, FlangOption, FC1Option]>,
HelpText<"Report missed transformations by optimization passes whose "
"name matches the given POSIX regular expression">;
----------------
IIUC, these are the all options for optimisation remarks? I would extract them
to a separate "block" and wrap like this:
```
//===----------------------------------------------------------------------===//
// Optimisation remark options
//===----------------------------------------------------------------------===//
let Flags = [CC1Option, FC1Option, FlangOption] in {
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157410/new/
https://reviews.llvm.org/D157410
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
