Sorry, I was distracted by other issues after I uploaded the patch.
I will take another look of the implementation.
Thanks,
Weiming
On 9/12/2016 1:31 PM, Sam Shepperd wrote:
phabricss added a comment.
On 09/12/2016 01:26 PM, Nick Lewycky wrote:
Firstly, I thought glibc had applied a patch to fix this bug? As in, the error
is correct and glibc fixed their bug?
I can confirm that the bug still exists in glibc 2.24 and HEAD from glibc git.
Also it appears that the issue on the llvm mailing list was just dropped
without any resolution:
r255371 - Error on redeclaring with a conflicting asm label
<http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146075.html>
../include/sys/stat.h:16:15: error: cannot apply asm label to function after
its first use
hidden_proto (__fxstat)
~~~~~~~~~~~~~~^~~~~~~~~
./../include/libc-symbols.h:420:19: note: expanded from macro 'hidden_proto'
__hidden_proto (name, , __GI_##name, ##attrs)
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./../include/libc-symbols.h:424:33: note: expanded from macro
'__hidden_proto'
extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
As far as your review of the patch by weimingz, that is beyond my skill level
so I will let him reply. Thanks!
https://reviews.llvm.org/D16171
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
