awarzynski added inline comments.
================ Comment at: flang/lib/Frontend/CompilerInvocation.cpp:156-158 +/// Parse a remark command line argument. It may be missing, disabled/enabled by +/// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'. +/// On top of that, it can be disabled/enabled globally by '-R[no-]everything'. ---------------- kiranchandramohan wrote: > awarzynski wrote: > > Could you give an example (and write a test ) for `-Rgroup=regexp`. Also, > > @kiranchandramohan , is this form actually needed? I am thinking that it's > > a complexity that could be avoided. It could definitely simplify this > > patch. > `Rpass=regex` is used, particularly `Rpass=.`. So this is required, but can > be deferred to a separate patch to simplify this one. > can be deferred to a separate patch to simplify this one That would be a small win - the complexity comes from the fact that we can't rely on TableGen to define all possible options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
