Author: Julian Schmidt Date: 2023-08-12T16:18:33Z New Revision: c3da99275a520b73235d975017502876e07e3e8e
URL: https://github.com/llvm/llvm-project/commit/c3da99275a520b73235d975017502876e07e3e8e DIFF: https://github.com/llvm/llvm-project/commit/c3da99275a520b73235d975017502876e07e3e8e.diff LOG: [clang-tidy] fix None tmpdir when exporting fixes in run-clang-tidy Differential https://reviews.llvm.org/D145477 removed the check for `(yaml and args.export_fixes)` in line 303 to skip looking for the `clang-apply-replacements` binary. However, the `tmpdir` variable was set in this true branch when exporting fixes and therefore is `None` when invoking run-clang-tidy with `run-clang-tidy -p . -export-fixes fixes.yaml`. Reviewed By: PiotrZSL Differential Revision: https://reviews.llvm.org/D157773 Added: Modified: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py index e0c2d63d2024cf..312d9241cfa57c 100755 --- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py +++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py @@ -389,6 +389,8 @@ def main(): clang_apply_replacements_binary = find_binary( args.clang_apply_replacements_binary, "clang-apply-replacements", build_path ) + + if args.fix or (yaml and args.export_fixes): tmpdir = tempfile.mkdtemp() try: _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
