MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/utils/TableGen/ClangOptionDocEmitter.cpp:43 +bool hasFlag(const Record *Option, StringRef OptionFlag) { + for (const Record *Flag : Option->getValueAsListOfDefs("Flags")) ---------------- For new functions, consider using `static` for internal linkage functions even if they are surrounded by an anonymous namespace, per https://llvm.org/docs/CodingStandards.html#anonymous-namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157146/new/ https://reviews.llvm.org/D157146 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits