DiggerLin added inline comments.
================
Comment at: clang/test/lit.cfg.py:391
if "system-aix" in config.available_features:
- config.substitutions.append(("llvm-nm", "env OBJECT_MODE=any llvm-nm"))
- config.substitutions.append(("llvm-ar", "env OBJECT_MODE=any llvm-ar"))
+ config.environment["OBJECT_MODE"] ="any"
----------------
jhenderson wrote:
> It might be a good idea for you to run the `black` tool on python changes, to
> ensure they conform to the coding standard, much like you do with
> clang-format for C++ changes.
thanks for let me know.
================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74
+ << " -X{32|64|32_64|any} - Specify which archive symbol tables "
+ "should be generated if they do not already exist (AIX OS only)\n";
}
----------------
jhenderson wrote:
> Strictly speaking, this should be "Big Archive formats only" not "AIX OS
> only" since theoretically you could have Big Archive archives on other
> platforms. However, I'm not bothered if you don't want to change this. The
> same probably goes for other tools for that matter, but don't change them now.
Strictly speaking, this should be "Big Archive format on AIX OS only" ,
in AIX OS , you can still input the -X option , but the X option not work for
gnu archive format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142660/new/
https://reviews.llvm.org/D142660
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
