ellis added inline comments.
================ Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:24 + +// RUN: rm -rf %t.profdir && mkdir %t.profdir + ---------------- Let's move this line down since we don't use it until line 31. ================ Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:30 + +// RUN: %clang_pgogen -o %t -g -mllvm --debug-info-correlate -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp +// RUN: env LLVM_PROFILE_FILE=%t.profdir/%m.proflite %run %t ---------------- This looks to be the same as line 2. Lets just reuse that executable. ================ Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:39 + +// RUN: %clang_pgogen -o %t.cov -g -mllvm --debug-info-correlate -mllvm -pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp +// RUN: env LLVM_PROFILE_FILE=%t.profdir/%m.cov.proflite %run %t.cov ---------------- Same here. This is the same as line 12. (And I believe these comments also apply to the Linux test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
