qiongsiwu1 added a comment. In D157280#4586078 <https://reviews.llvm.org/D157280#4586078>, @MaskRay wrote:
> Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! ================ Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, - /* IsCS */ true, PGOOpt->CSProfileGenFile, - PGOOpt->ProfileRemappingFile, + /* IsCS */ true, PGOOpt->AtomicCounterUpdate, + PGOOpt->CSProfileGenFile, PGOOpt->ProfileRemappingFile, ---------------- MaskRay wrote: > The canonical way to specify the parameter name is `/*IsCS=*/true` Ah thanks for pointing it out! Let me fix it in a later NFC patch if that is OK. There are quite a few changes required and they would make the actual feature harder to see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
