MaskRay accepted this revision. MaskRay added subscribers: python3kgae, beanz. MaskRay added a comment. This revision is now accepted and ready to land.
> ... but it really doesn't scale well, as can be seen by things like the > somewhat recently introduced CLDXCOption. FYI @beanz @python3kgae D128462 <https://reviews.llvm.org/D128462> ================ Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:387 + // The option visibility flags. + OS << ", "; ---------------- If we make "flags" & "visibility", it's best not to use "visibility flags" to add possible confusion to readers. This also applies to this sentence in the summary `... the only "subtractive" visibility flag be "HelpHidden"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
