4vtomat updated this revision to Diff 550185.
4vtomat added a comment.
1. Apply clang-format for this patch
2. Replace FileCheck --implicit-check-not=warning: with %clang -Werror
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146054/new/
https://reviews.llvm.org/D146054
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/FrontendOptions.h
clang/lib/Driver/Driver.cpp
clang/test/Driver/print-supported-extensions.c
clang/tools/driver/cc1_main.cpp
llvm/include/llvm/Support/RISCVISAInfo.h
llvm/lib/Support/RISCVISAInfo.cpp
Index: llvm/lib/Support/RISCVISAInfo.cpp
===================================================================
--- llvm/lib/Support/RISCVISAInfo.cpp
+++ llvm/lib/Support/RISCVISAInfo.cpp
@@ -208,6 +208,29 @@
#endif
}
+void llvm::riscvExtensionsHelp() {
+ outs() << "All available -march extensions for RISC-V\n\n";
+ outs() << '\t' << left_justify("Name", 20) << "Version\n";
+
+ RISCVISAInfo::OrderedExtensionMap ExtMap;
+ for (const auto &E : SupportedExtensions)
+ ExtMap[E.Name] = {E.Version.Major, E.Version.Minor};
+ for (const auto &E : ExtMap)
+ outs() << format("\t%-20s%d.%d\n", E.first.c_str(), E.second.MajorVersion,
+ E.second.MinorVersion);
+
+ outs() << "\nExperimental extensions\n";
+ ExtMap.clear();
+ for (const auto &E : SupportedExperimentalExtensions)
+ ExtMap[E.Name] = {E.Version.Major, E.Version.Minor};
+ for (const auto &E : ExtMap)
+ outs() << format("\t%-20s%d.%d\n", E.first.c_str(), E.second.MajorVersion,
+ E.second.MinorVersion);
+
+ outs() << "\nUse -march to specify the target's extension.\n"
+ "For example, clang -march=rv32i_v1p0\n";
+}
+
static bool stripExperimentalPrefix(StringRef &Ext) {
return Ext.consume_front("experimental-");
}
Index: llvm/include/llvm/Support/RISCVISAInfo.h
===================================================================
--- llvm/include/llvm/Support/RISCVISAInfo.h
+++ llvm/include/llvm/Support/RISCVISAInfo.h
@@ -22,6 +22,8 @@
unsigned MinorVersion;
};
+void riscvExtensionsHelp();
+
class RISCVISAInfo {
public:
RISCVISAInfo(const RISCVISAInfo &) = delete;
Index: clang/tools/driver/cc1_main.cpp
===================================================================
--- clang/tools/driver/cc1_main.cpp
+++ clang/tools/driver/cc1_main.cpp
@@ -38,6 +38,7 @@
#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/Path.h"
#include "llvm/Support/Process.h"
+#include "llvm/Support/RISCVISAInfo.h"
#include "llvm/Support/Signals.h"
#include "llvm/Support/TargetSelect.h"
#include "llvm/Support/TimeProfiler.h"
@@ -221,6 +222,10 @@
if (Clang->getFrontendOpts().PrintSupportedCPUs)
return PrintSupportedCPUs(Clang->getTargetOpts().Triple);
+ // --print-supported-extensions takes priority over the actual compilation.
+ if (Clang->getFrontendOpts().PrintSupportedExtensions)
+ return llvm::riscvExtensionsHelp(), 0;
+
// Infer the builtin include path if unspecified.
if (Clang->getHeaderSearchOpts().UseBuiltinIncludes &&
Clang->getHeaderSearchOpts().ResourceDir.empty())
Index: clang/test/Driver/print-supported-extensions.c
===================================================================
--- /dev/null
+++ clang/test/Driver/print-supported-extensions.c
@@ -0,0 +1,129 @@
+/// Test that --print-supported-extensions lists supported extensions.
+
+// REQUIRES: riscv-registered-target
+
+// RUN: %clang -Werror --target=riscv64 --print-supported-extensions 2>&1 | \
+// RUN: FileCheck --strict-whitespace --match-full-lines %s
+
+// CHECK:Target: riscv64
+// CHECK:All available -march extensions for RISC-V
+// CHECK: Name Version
+// CHECK-NEXT: i 2.1
+// CHECK-NEXT: e 2.0
+// CHECK-NEXT: m 2.0
+// CHECK-NEXT: a 2.1
+// CHECK-NEXT: f 2.2
+// CHECK-NEXT: d 2.2
+// CHECK-NEXT: c 2.0
+// CHECK-NEXT: v 1.0
+// CHECK-NEXT: h 1.0
+// CHECK-NEXT: zicbom 1.0
+// CHECK-NEXT: zicbop 1.0
+// CHECK-NEXT: zicboz 1.0
+// CHECK-NEXT: zicntr 1.0
+// CHECK-NEXT: zicsr 2.0
+// CHECK-NEXT: zifencei 2.0
+// CHECK-NEXT: zihintpause 2.0
+// CHECK-NEXT: zihpm 1.0
+// CHECK-NEXT: zmmul 1.0
+// CHECK-NEXT: zawrs 1.0
+// CHECK-NEXT: zfh 1.0
+// CHECK-NEXT: zfhmin 1.0
+// CHECK-NEXT: zfinx 1.0
+// CHECK-NEXT: zdinx 1.0
+// CHECK-NEXT: zca 1.0
+// CHECK-NEXT: zcb 1.0
+// CHECK-NEXT: zcd 1.0
+// CHECK-NEXT: zce 1.0
+// CHECK-NEXT: zcf 1.0
+// CHECK-NEXT: zcmp 1.0
+// CHECK-NEXT: zcmt 1.0
+// CHECK-NEXT: zba 1.0
+// CHECK-NEXT: zbb 1.0
+// CHECK-NEXT: zbc 1.0
+// CHECK-NEXT: zbkb 1.0
+// CHECK-NEXT: zbkc 1.0
+// CHECK-NEXT: zbkx 1.0
+// CHECK-NEXT: zbs 1.0
+// CHECK-NEXT: zk 1.0
+// CHECK-NEXT: zkn 1.0
+// CHECK-NEXT: zknd 1.0
+// CHECK-NEXT: zkne 1.0
+// CHECK-NEXT: zknh 1.0
+// CHECK-NEXT: zkr 1.0
+// CHECK-NEXT: zks 1.0
+// CHECK-NEXT: zksed 1.0
+// CHECK-NEXT: zksh 1.0
+// CHECK-NEXT: zkt 1.0
+// CHECK-NEXT: zve32f 1.0
+// CHECK-NEXT: zve32x 1.0
+// CHECK-NEXT: zve64d 1.0
+// CHECK-NEXT: zve64f 1.0
+// CHECK-NEXT: zve64x 1.0
+// CHECK-NEXT: zvfh 1.0
+// CHECK-NEXT: zvl1024b 1.0
+// CHECK-NEXT: zvl128b 1.0
+// CHECK-NEXT: zvl16384b 1.0
+// CHECK-NEXT: zvl2048b 1.0
+// CHECK-NEXT: zvl256b 1.0
+// CHECK-NEXT: zvl32768b 1.0
+// CHECK-NEXT: zvl32b 1.0
+// CHECK-NEXT: zvl4096b 1.0
+// CHECK-NEXT: zvl512b 1.0
+// CHECK-NEXT: zvl64b 1.0
+// CHECK-NEXT: zvl65536b 1.0
+// CHECK-NEXT: zvl8192b 1.0
+// CHECK-NEXT: zhinx 1.0
+// CHECK-NEXT: zhinxmin 1.0
+// CHECK-NEXT: svinval 1.0
+// CHECK-NEXT: svnapot 1.0
+// CHECK-NEXT: svpbmt 1.0
+// CHECK-NEXT: xcvalu 1.0
+// CHECK-NEXT: xcvbi 1.0
+// CHECK-NEXT: xcvbitmanip 1.0
+// CHECK-NEXT: xcvmac 1.0
+// CHECK-NEXT: xcvsimd 1.0
+// CHECK-NEXT: xsfcie 1.0
+// CHECK-NEXT: xsfvcp 1.0
+// CHECK-NEXT: xtheadba 1.0
+// CHECK-NEXT: xtheadbb 1.0
+// CHECK-NEXT: xtheadbs 1.0
+// CHECK-NEXT: xtheadcmo 1.0
+// CHECK-NEXT: xtheadcondmov 1.0
+// CHECK-NEXT: xtheadfmemidx 1.0
+// CHECK-NEXT: xtheadmac 1.0
+// CHECK-NEXT: xtheadmemidx 1.0
+// CHECK-NEXT: xtheadmempair 1.0
+// CHECK-NEXT: xtheadsync 1.0
+// CHECK-NEXT: xtheadvdot 1.0
+// CHECK-NEXT: xventanacondops 1.0
+// CHECK-EMPTY:
+// CHECK:Experimental extensions
+// CHECK-NEXT: zicond 1.0
+// CHECK-NEXT: zihintntl 0.2
+// CHECK-NEXT: zacas 1.0
+// CHECK-NEXT: zfa 0.2
+// CHECK-NEXT: zfbfmin 0.8
+// CHECK-NEXT: ztso 0.1
+// CHECK-NEXT: zvbb 1.0
+// CHECK-NEXT: zvbc 1.0
+// CHECK-NEXT: zvfbfmin 0.8
+// CHECK-NEXT: zvfbfwma 0.8
+// CHECK-NEXT: zvkg 1.0
+// CHECK-NEXT: zvkn 1.0
+// CHECK-NEXT: zvknc 1.0
+// CHECK-NEXT: zvkned 1.0
+// CHECK-NEXT: zvkng 1.0
+// CHECK-NEXT: zvknha 1.0
+// CHECK-NEXT: zvknhb 1.0
+// CHECK-NEXT: zvks 1.0
+// CHECK-NEXT: zvksc 1.0
+// CHECK-NEXT: zvksed 1.0
+// CHECK-NEXT: zvksg 1.0
+// CHECK-NEXT: zvksh 1.0
+// CHECK-NEXT: zvkt 1.0
+// CHECK-NEXT: smaia 1.0
+// CHECK-NEXT: ssaia 1.0
+// CHECK-EMPTY:
+// CHECK:Use -march to specify the target's extension.
+// CHECK-NEXT:For example, clang -march=rv32i_v1p0
Index: clang/lib/Driver/Driver.cpp
===================================================================
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -2131,7 +2131,8 @@
if (C.getArgs().hasArg(options::OPT_v) ||
C.getArgs().hasArg(options::OPT__HASH_HASH_HASH) ||
- C.getArgs().hasArg(options::OPT_print_supported_cpus)) {
+ C.getArgs().hasArg(options::OPT_print_supported_cpus) ||
+ C.getArgs().hasArg(options::OPT_print_supported_extensions)) {
PrintVersion(C, llvm::errs());
SuppressMissingInputWarning = true;
}
@@ -4312,16 +4313,30 @@
C.MakeAction<IfsMergeJobAction>(MergerInputs, types::TY_Image));
}
- // If --print-supported-cpus, -mcpu=? or -mtune=? is specified, build a custom
- // Compile phase that prints out supported cpu models and quits.
- if (Arg *A = Args.getLastArg(options::OPT_print_supported_cpus)) {
- // Use the -mcpu=? flag as the dummy input to cc1.
- Actions.clear();
- Action *InputAc = C.MakeAction<InputAction>(*A, types::TY_C);
- Actions.push_back(
- C.MakeAction<PrecompileJobAction>(InputAc, types::TY_Nothing));
- for (auto &I : Inputs)
- I.second->claim();
+ for (auto Opt : {options::OPT_print_supported_cpus,
+ options::OPT_print_supported_extensions}) {
+ // If --print-supported-cpus, -mcpu=? or -mtune=? is specified, build a
+ // custom Compile phase that prints out supported cpu models and quits.
+ //
+ // If --print-supported-extensions is specified, call the helper function
+ // RISCVMarchHelp in RISCVISAInfo.cpp that prints out supported extensions
+ // and quits.
+ if (Arg *A = Args.getLastArg(Opt)) {
+ if (Opt == options::OPT_print_supported_extensions &&
+ !C.getDefaultToolChain().getTriple().isRISCV()) {
+ C.getDriver().Diag(diag::err_opt_not_valid_on_target)
+ << "--print-supported-extensions";
+ return;
+ }
+
+ // Use the -mcpu=? flag as the dummy input to cc1.
+ Actions.clear();
+ Action *InputAc = C.MakeAction<InputAction>(*A, types::TY_C);
+ Actions.push_back(
+ C.MakeAction<PrecompileJobAction>(InputAc, types::TY_Nothing));
+ for (auto &I : Inputs)
+ I.second->claim();
+ }
}
// Call validator for dxil when -Vd not in Args.
Index: clang/include/clang/Frontend/FrontendOptions.h
===================================================================
--- clang/include/clang/Frontend/FrontendOptions.h
+++ clang/include/clang/Frontend/FrontendOptions.h
@@ -283,6 +283,9 @@
/// print the supported cpus for the current target
unsigned PrintSupportedCPUs : 1;
+ /// Print the supported extensions for the current target.
+ unsigned PrintSupportedExtensions : 1;
+
/// Show the -version text.
unsigned ShowVersion : 1;
Index: clang/include/clang/Driver/Options.td
===================================================================
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -4582,6 +4582,10 @@
HelpText<"Print supported cpu models for the given target (if target is not specified,"
" it will print the supported cpus for the default target)">,
MarshallingInfoFlag<FrontendOpts<"PrintSupportedCPUs">>;
+def print_supported_extensions : Flag<["-", "--"], "print-supported-extensions">,
+ Group<CompileOnly_Group>, Flags<[CC1Option, CoreOption]>,
+ HelpText<"Print supported extensions for RISC-V">,
+ MarshallingInfoFlag<FrontendOpts<"PrintSupportedExtensions">>;
def : Flag<["-"], "mcpu=help">, Alias<print_supported_cpus>;
def : Flag<["-"], "mtune=help">, Alias<print_supported_cpus>;
def time : Flag<["-"], "time">,
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
