DavidSpickett added a comment.

We also had a failure looking for the mangled name on Windows on Arm: 
https://lab.llvm.org/buildbot/#/builders/65/builds/10954

The triple fix may take care of that too.

> Also, consider spreading out commits a bit so that if one breaks something, 
> it's easily to see which one it was.

Definitely.

Another option for dependent patches that must go in together is to add `[1/N]` 
so we know it's essentially one large change, and can revert accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157808/new/

https://reviews.llvm.org/D157808

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to