jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, but do not remove the Attribute from our set, add it to the tests. The
functions are nounwind.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:532
MemoryAttr(MemoryEffects::argMemOnly() |
MemoryEffects::inaccessibleMemOnly(ModRefInfo::Ref)))
- : AttributeSet(EnumAttr(NoUnwind)))
__OMP_ATTRS_SET(
----------------
TIFitis wrote:
> Clang test //llvm/clang/test/OpenMP/ordered_codegen.cpp// complains about the
> presence of `NoUnwind` attribute for the `__kmpc_dispatch_*` functions.
>
> This change doesn't seem to break any other test, although I am not sure if
> we should be creating a new `Attr` group for the `__kmpc_dispatch` functions
> and remove the `NoUnwind` `Attr` only there.
Add nounwind to the tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157994/new/
https://reviews.llvm.org/D157994
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
