kaz7 marked 3 inline comments as done.
kaz7 added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:5166
+// VE feature flags
+let Flags = [TargetSpecific, CC1Option] in {
+def mvevpu : Flag<["-"], "mvevpu">, Group<m_ve_Features_Group>,
----------------
MaskRay wrote:
> Other feature group options don't set CC1Option: we do not need them as CC1
> options (e.g. `-Xclang -msse4`)
Thank you. I was wondering which group options are required here.
================
Comment at: clang/include/clang/Driver/Options.td:5169
+ HelpText<"Emit VPU instructions for VE">;
+def mno_vevpu : Flag<["-"], "mno-vevpu">, Group<m_ve_Features_Group>,
+ HelpText<"Do not emit VPU instructions for VE">;
----------------
MaskRay wrote:
> In general, we just need documentation for the non-default option (let's say
> `-mvevpu`). Documentation for the opposite `-mno-mvevpu` is just boilerplate
> and not very useful.
I see. Changed.
================
Comment at: clang/test/Driver/ve-features.c:1
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mvevpu 2>&1 | FileCheck
%s -check-prefix=VEVPU
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mno-vevpu 2>&1 |
FileCheck %s -check-prefix=NO-VEVPU
----------------
MaskRay wrote:
> `-target ` has been deprecated since Clang 3.4. Use `--target=`
I didn't know that. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
