aaron.ballman added a comment.

Having worked with phabricator for a long time, this is the first time I've 
seen it "pull a github" where it just doesn't want to show you the content of 
anything in the review. Ugh, sorry for that! You can click on Changeset List 
above to see the list of changed files, and you can click on individual files 
to see changes and leave comments, which is pretty awful because of the amount 
of clicking involved but does work. I could split it up by top-level directory, 
but then we'd have approx 30 reviews to cover which feels like more effort than 
an NFC change to comments is worth. I'd recommend we try to advance with this 
review as best we can (I'm assuming there's only some subset of files people 
are interested in trying to retain comments for, so thinking that clicking 
around won't be too awful), but if others have a suggestion on a better way 
that isn't overly onerous, I'm happy to consider it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158071/new/

https://reviews.llvm.org/D158071

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to