MaskRay added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1787 + if (!VCI->isMinSignedValue()) { + return EmitAbs(CGF, ArgValue, true); + } ---------------- MaskRay wrote: > nit: we delete braces in this cascading case > > https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements Thanks. I think the coding standard omits the outer braces as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits