ChuanqiXu added a comment. @sammccall Hi, Sam. Thanks for your high-quality comments! It is valuable. All the low-level inline comments are helpful. But I didn't reply them for the suggested direction in the higher level comments.
I'll repeat your suggestion in my mind again to avoid any misunderstandings: While we should leave the space for future development, we should do the following thing in the initial patch: > Don't attempt any cross-file or cross-version coordination: i.e. don't try to > reuse BMIs between different files, don't try to reuse BMIs between > (preamble) reparses of the same file, don't try to persist the module graph. > Instead, when building a preamble, synchronously scan for the module graph, > build the required PCMs on the single preamble thread with filenames private > to that preamble, and then proceed to build the preamble. Do I understand right? If I understand correctly, I fully agree with the direction. We can go slowly, as long as we keep moving forward. Then I'd like to leave the patch as-is for referencing and create new patches following the suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
