qiucf added a comment.

In D158066#4601785 <https://reviews.llvm.org/D158066#4601785>, @nemanjai wrote:

> It should be perfectly fine to provide pre-defined macros for these to match 
> GCC on PowerPC. The reason we went with the macro solution is to avoid 
> polluting the builtins namespace for other targets.
>
> Also, please add some C++ tests for these PPC wrappers so that we aren't 
> surprised again when someone tries to use these in their C++ code.

It seems these macros do not always work for all PowerPC targets:

  // -target=ppc64le -mcpu=power9 do not work
  // -target=ppc64le-unknown-linux-gnu -mcpu=power9 work
  long calldarn(void) { return __darn(); }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158066/new/

https://reviews.llvm.org/D158066

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D158066: [PowerPC] Fix... Qiu Chaofan via Phabricator via cfe-commits

Reply via email to