lukasza added a comment.

The delta from https://reviews.llvm.org/D155895 is in 
`clang/test/SemaCXX/attr-trivial-abi.cpp` where 1) a comment has been added 
above the non-trivial move constructor of the `Trivial` test helper and 2) test 
expectations have been tweaked to account for `_WIN64` and `__MINGW32__` 
(cargo-culting these conditions from the already-existing tests in the top part 
of this test file).

I have considered making Windows and non-Windows behaving in the same way, 
which would require making `Trivial` trivially-copyable (and consequently 
trivially-movable).  This wouldn't repro the original problem, so I abandoned 
this direction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158532/new/

https://reviews.llvm.org/D158532

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D158532: Anonym... Łukasz Anforowicz via Phabricator via cfe-commits
    • [PATCH] D158532: A... Łukasz Anforowicz via Phabricator via cfe-commits

Reply via email to