ABataev added a comment.

In D158559#4608397 <https://reviews.llvm.org/D158559#4608397>, 
@ivanrodriguez3753 wrote:

> In D158559#4608388 <https://reviews.llvm.org/D158559#4608388>, @ABataev wrote:
>
>> 1. Always provide full context in the patch.
>
> Sure, would you mind mentioning what's missing? Or do you mean the stuff from 
> debug output being shortened, as well as LLVM IR being only snippets?

I mean, provide full diff context, read the docs how to upload patches for the 
review. 
https://www.llvm.org/docs/Phabricator.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158559/new/

https://reviews.llvm.org/D158559

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to