owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:389 auto *ClosingLine = AnnotatedLines.begin() + ClosingLineIndex + 1; - auto OutdentBy = I[J]->Level - TheLine->Level; + int OutdentBy = I[J]->Level - TheLine->Level; + assert(OutdentBy >= 0); ---------------- I forgot to suggest `const`. ================ Comment at: clang/unittests/Format/FormatTest.cpp:4231-4234 + "// block for debug mode\n" + "#ifndef NDEBUG\n" + "#endif\n" + "}}} // namespace ns1::ns2::ns3", ---------------- Did you run `git-clang-format`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits